Re: [PATCH] Fix nopush cleanup for SPDY

Hello!

On Tue, Jun 11, 2013 at 01:00:42PM +0400, Yury Kirpichev wrote:

> Could you please take a look at patch below.
> I've tried to fix problem that TCP_CORK option is not cleaned in SPDY case.

The patch looks wrong.

- It introduces layering violation and build failure --without-http
as a result. You may have better luck focusing on a problem you
want to fix, and avoiding unrelated changes as much as possible.

- It tries to restore nopush after each c->send_chain() call,
which looks suboptimal. It probably should be done if there are no
pending data to send.

--
Maxim Dounin
http://nginx.org/en/donation.html

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel