Re: [PATCH] ngx_mail_ssl_module / ecdh_curve

Hello!

On Mon, May 20, 2013 at 11:37:39PM +0200, Filipe Da Silva wrote:

[...]

> > > # HG changeset patch
> > > # User fds <fdasilvayy@gmail.com>
> >
> > Could you please use a proper name here? Just "fds" looks wierd.
> >
> > > # Date 1368197625 -7200
> > > # Node ID f6c3e219648f47eaa65ab43a8189af31f7babc69
> > > # Parent 7ffe7f3be4045dbc7478248370b473271660e473
> > > Missing call to ngx_ssl_ecdh_curve in mail_ssl_module
> >
> > Please use trailing dot and "Mail:" prefix for mail-related
> > changes.
> >
> > That is, I would like to see something like this here:
> >
> > Mail: missing ngx_ssl_ecdh_curve() call.

[...]

> # HG changeset patch
> # User F. da Silva<fdasilvayy@gmail.com>

At least space after a name seems to be missing.

What about "Filipe Da Silva <fdasilvayy@gmail.com>", as used in
the From address of your messages?

> # Date 1368197625 -7200
> # Fri May 10 16:53:45 2013 +0200
> # Node ID 24369ba28ede7baea634de2dfbab899925830f34
> # Parent cfab1e7e4ac2f0d17199ee1d49ac4647b63746d3
> Mail: Missing ngx_ssl_ecdh_curve call.

No capitalization after after a prefix, please. Parentheses after
a function name is also generally good idea to explicitly mark
functions. That is, I would like to see what was previously
suggested:

Mail: missing ngx_ssl_ecdh_curve() call.

(Please let me know if you'll prefer me to fix it myself. It
would be better if you'll fix it yourself though - especially if
you are planning to submit more patches.)

(Please also consider switching off html in your messages to
nginx-devel@. Thank you.)

--
Maxim Dounin
http://nginx.org/en/donation.html

_______________________________________________
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel